Configurable max_tokens/max_completion_tokens key #399
+14
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Michael Smith <[email protected]>
sjmonson
changed the title
Signed-off-by: Samuel Monson <[email protected]>
Signed-off-by: Samuel Monson <[email protected]>
sjmonson
force-pushed
the
fix/drop_max_completion_tokens
branch
from
68e69bc to
ef981fd
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements configurable request keys for output token limits in OpenAI API calls. Instead of hardcoding both max_tokens and max_completion_tokens in all requests, the system now uses the appropriate key based on endpoint type through a new environment variable configuration.
- Adds
GUIDELLM__OPENAI__MAX_OUTPUT_KEYconfiguration mapping endpoint types to their respective output token keys - Updates payload generation to use the configured key instead of setting both keys
- Fixes test assertions to match the new single-key approach
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/guidellm/config.py | Adds new max_output_key configuration with defaults for text and chat completions |
| src/guidellm/backend/openai.py | Updates payload generation to use configurable key and adds type definitions |
| tests/unit/conftest.py | Removes duplicate token limit assertions and fixes mock response generation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jaredoconnell
approved these changes
Oct 9, 2025
markurtz
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes the
max_tokensrequest key configurable through an environment variable per endpoint type. Defaults tomax_tokensfor legacycompletionsandmax_completion_tokensforchat/completionsDetails
GUIDELLM__OPENAI__MAX_OUTPUT_KEYconfig option which is a dict mapping from route name -> output tokens key. Default is{"text_completions": "max_tokens", "chat_completions": "max_completion_tokens"}Test Plan
Related Issues
Use of AI
## WRITTEN BY AI ##)